Allow setting configuration for timeouts #196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elhu
force-pushed
the
allow-timeout-configuration
branch
from
fbc0b4b to
84248e1
Compare
|
@dlitvakb did you get a chance to take a look at this PR? |
|
Hey @elhu, This is on my list of tasks for today, I'll probably have it included in a release either today or tomorrow. Cheers |
|
This has been released in version Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #186, the inability to set timeouts for Contentful's HTTP client makes it hard to mitigate availability issues.
This PR is a first stab at making the timeouts possible to configure.
It adds three configuration options, that must all be set together or not at all (because the default in HTTP is 0.25s for each when enabling timeouts):
timeout_readtimeout_connecttimeout_writeUpdating the HTTP gem would make it easier to set one global timeout, which would be more user friendly, but I thought this was a bit out of scope for this particular contribution.
Regarding the rubocop issues: I've fixed the ones that made sense, but the last three ones should be decided upon by maintainers.